Skip to content

Support \r and \r\n line breaks in tokenizer #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2019
Merged

Support \r and \r\n line breaks in tokenizer #54

merged 2 commits into from
Apr 27, 2019

Conversation

nickolay
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 158

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 85.401%
Totals Coverage Status
Change from base Build 148: 0.8%
Covered Lines: 2644
Relevant Lines: 3096
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 162

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 85.382%
Totals Coverage Status
Change from base Build 148: 0.7%
Covered Lines: 2640
Relevant Lines: 3092
💛 - Coveralls

andygrove
andygrove approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickolay !

@andygrove andygrove merged commit 64b1ea7 into apache:master Apr 27, 2019
@nickolay nickolay deleted the windows-newlines branch April 27, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickolay @coveralls @andygrove